chore: sign release please commits#22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Release Please currently creates unsigned release PR commits, which can be blocked by the repository's verified-signature branch protection. This configures the release workflow to use the hardened signed-commit fork and adds a helper for setting up the signing key secrets.
Summary of Changes
CHANGELOG.mdfrom dprint formatting.5931f1e9ef68429590dc13ea0655d0a2708cbd2f.misetasks and a helper script to generate/export the Release Please GPG signing key.Testing
mise run fmt:checkmise run testbash -n scripts/release-please-gpg-key.shDependencies/Special Considerations
Before the signed Release Please workflow can work, configure
RELEASE_PLEASE_GPG_PRIVATE_KEY,RELEASE_PLEASE_GPG_KEY_ID, and optionallyRELEASE_PLEASE_GPG_PASSPHRASE, then add the public key to GitHub for the signer identity.